Equivalence cleanups #2124
Merged
Equivalence cleanups #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
commented
Oct 25, 2024
| #[local] | ||
| Hint Immediate isequiv_contr_map : typeclass_instances. | ||
| (** As usual, we can't make both of these [Instances]. *) | ||
| #[export] Hint Immediate isequiv_contr_map : typeclass_instances. |
Collaborator
Author
There was a problem hiding this comment.
This was already a global export, but it was done after the section was closed, so there is no change here.
Comment on lines
+26
to
+27
| lhs_V nrapply transport_paths_l. | ||
| lhs_V nrapply transport_compose. |
Collaborator
Author
There was a problem hiding this comment.
These are the only changes to the proofs.
Alizter
approved these changes
Oct 25, 2024
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
LGTM, free to merge after one suggestion
Co-authored-by: Ali Caglayan <[email protected]>
Collaborator
Author
|
@Alizter Thanks. I also updated one comment in Types/Sigma.v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly changes Types/Equiv.v:
In Equiv/BiInv.v, I just reduced the imports.