Improvements to make_equiv #1869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit changes
cbntohnfin themake_equivtactic, so that the lazymatch can correctly detect path types. If the path type was hidden in record or class, likeIsUnitPreserving, thenmake_equivwould inadvertently destruct it withelim. With the change, one proof in Group.v becomes much simpler.make_equivfailed there before this change.The second commit is independent and just gives some improvements coming from looking at places where
make_equivwas used. Thecbninserted in one spot speeds up themake_equivthere.