Skip to content

Conversation

@jdchristensen
Copy link
Collaborator

@jdchristensen jdchristensen commented Feb 24, 2024

The first commit changes cbn to hnf in the make_equiv tactic, so that the lazymatch can correctly detect path types. If the path type was hidden in record or class, like IsUnitPreserving, then make_equiv would inadvertently destruct it with elim. With the change, one proof in Group.v becomes much simpler. make_equiv failed there before this change.

The second commit is independent and just gives some improvements coming from looking at places where make_equiv was used. The cbn inserted in one spot speeds up the make_equiv there.

@jdchristensen
Copy link
Collaborator Author

I tested that the change to hnf has no measurable affect on the build time.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@jdchristensen jdchristensen merged commit 7250a9b into HoTT:master Feb 24, 2024
@jdchristensen jdchristensen deleted the make_equiv branch February 24, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants