Updates to EMSpace, Join/Core, HSpaces/* and other things #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
reviewed
Dec 29, 2023
Alizter
reviewed
Dec 29, 2023
Alizter
reviewed
Dec 29, 2023
Alizter
reviewed
Dec 29, 2023
Collaborator
|
I had a quick look today; will take a more detailed look tomorrow. |
Alizter
approved these changes
Dec 30, 2023
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
Looks good to me. I just have some comments, but they aren't fully necessary if you don't have time to act on them.
Collaborator
Author
|
@Alizter Let me know what you think about the changes to Basics/Trunc.v. |
Collaborator
|
Changes look good. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things related to H-spaces, Eilenberg-Mac Lane spaces and loop spaces which helps WIP on bands, central types, Euler classes, etc. The commit titles give a reasonable summary. Many commits are independent, and the library builds after each commit. I also improved the just-added
pelimtactic and added tests. I usedpelimin a couple of places; there were other possible places too, but I left the explicit proofs in place.