Fix off-by-one buffer overflow in integration test mergeFunction#243
Open
RaionG18 wants to merge 1 commit into
Open
Fix off-by-one buffer overflow in integration test mergeFunction#243RaionG18 wants to merge 1 commit into
RaionG18 wants to merge 1 commit into
Conversation
`resultpath` was allocated as `strlen(destdir) + strlen("/result.dat")`
bytes, but the subsequent sprintf writes that many characters plus the
terminating NUL, overflowing the heap buffer by one byte.
This is harmless under low optimization, but with _FORTIFY_SOURCE active
(e.g. -O3 on recent GCC/glibc) the fortified sprintf detects the overflow
and aborts with "*** buffer overflow detected ***", crashing the
RunTestSplitMergeAndMapReduceFunction integration test.
Reserve one extra byte for the NUL terminator.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 63.45% 63.46% +0.01%
==========================================
Files 78 79 +1
Lines 3273 3274 +1
Branches 2008 2008
==========================================
+ Hits 2077 2078 +1
+ Misses 938 399 -539
- Partials 258 797 +539 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Using LLMs might have licensing issues. Removing approval pending investigation of licensing issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resultpathwas allocated asstrlen(destdir) + strlen("/result.dat")bytes, but the subsequent sprintf writes that many characters plus the terminating NUL, overflowing the heap buffer by one byte.With _FORTIFY_SOURCE active (e.g. -O3 on recent GCC/glibc) the fortified sprintf detects the overflow and aborts with "*** buffer overflow detected ***", crashing the RunTestSplitMergeAndMapReduceFunction integration test.
Reserve one extra byte for the NUL terminator.