Skip to content

Conversation

@arielj
Copy link
Collaborator

@arielj arielj commented Jul 20, 2025

Filter out a few more settings per platform to make logs easier to read for support threads


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added this to the 2.18.0 milestone Jul 20, 2025
@arielj arielj requested review from a team, Etaash-mathamsetty and flavioislima and removed request for a team July 20, 2025 03:31
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 20, 2025
if (isLinux) {
delete gameSettings.enableMsync
delete gameSettings.wineCrossoverBottle
delete gameSettings.advertiseAvxForRosetta
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for mac

delete gameSettings.autoInstallDxvk
delete gameSettings.autoInstallVkd3d
} else {
delete gameSettings.useSteamRuntime
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't show this setting for wine

delete gameSettings.showFps
delete gameSettings.disableUMU
delete gameSettings.useSteamRuntime
delete gameSettings.enableFsync
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't show these settings on mac

delete gameSettings.enableWineWayland
delete gameSettings.enableHDR
delete gameSettings.showMangohud
delete gameSettings.showFps
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually have the show fps option on mac, this was wrong

delete gameSettings.nvidiaPrime
delete gameSettings.disableUMU
delete gameSettings.advertiseAvxForRosetta
delete gameSettings.useSteamRuntime
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't show these options on windows

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit 636a29b into main Jul 21, 2025
9 checks passed
@arielj arielj deleted the log-settings-filters branch July 21, 2025 19:54
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants