Skip to content

Conversation

@arielj
Copy link
Collaborator

@arielj arielj commented May 31, 2025

When using Heroic as a Flatpak and mangohud or gamescope are not found, the message only told the user to install them and add them to the PATH, when the solution is to actually install the flatpak packages of those tools (because users might see they actually have the tools installed and in the PATH, but they might not know they need the flatpak version)

Since they also have to install the correct version matching the Flatpak runtime, I included that in the message to make it more obvious.

This should solve many issues of users not knowing how to solve the missing mangohud/gamescope problems.

Also, since isFlatpak is a static value that can never change, we don't need an api endpoint, we can just inject the value into the window object at boot using the preload script (we are already sending some static data there), this removes a little bit of complexity in a few places, which I included in this PR.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, biliesilva, flavioislima and imLinguin and removed request for a team May 31, 2025 04:57
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 31, 2025
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit 8579d6f into main Jun 3, 2025
9 checks passed
@arielj arielj deleted the improve-missing-mangohud-gamescope-flatpak branch June 3, 2025 22:04
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants