Skip to content

[TECH]: disable umu by default #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imLinguin merged 1 commit into from
Aug 4, 2024
Merged

[TECH]: disable umu by default #3899

imLinguin merged 1 commit into from
Aug 4, 2024

Conversation

@imLinguin
Copy link
Member

@imLinguin imLinguin commented Aug 4, 2024

as discussed we are going to disable umu out of the box, since before it releases it requires additional steps to get working

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 4, 2024
@imLinguin imLinguin requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, arielj and flavioislima and removed request for a team August 4, 2024 12:40
arielj
arielj approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested by deleting heroic's config

@imLinguin imLinguin merged commit 177b0b9 into main Aug 4, 2024
@imLinguin imLinguin deleted the tech/umu-off branch August 4, 2024 13:07
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees

No one assigned

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imLinguin @arielj