Skip to content

[Fix] Game Status type #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CommandMC merged 1 commit into from
Jan 31, 2024
Merged

[Fix] Game Status type #3481

CommandMC merged 1 commit into from
Jan 31, 2024

Conversation

@CommandMC
Copy link
Member

@CommandMC CommandMC commented Jan 31, 2024

Not quite sure how this happened, but #3448 had some conflicts with types on the main branch

Joinked the change from https://discord.com/channels/812703221789097985/812703424995000361/1201963518233161788

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 31, 2024
@CommandMC CommandMC requested review from a team, Etaash-mathamsetty, Nocccer, arielj, flavioislima and imLinguin and removed request for a team January 31, 2024 09:46
@CommandMC CommandMC merged commit 6f92049 into main Jan 31, 2024
@CommandMC CommandMC deleted the fix/gamestatus-type branch January 31, 2024 09:57
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@imLinguin imLinguin imLinguin approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees

No one assigned

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CommandMC @imLinguin