Skip to content

Conversation

@arielj
Copy link
Collaborator

@arielj arielj commented Jan 2, 2024

This PR fixes 2 problems related to the download progress of wines:

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 2, 2024
@arielj arielj requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, flavioislima and imLinguin and removed request for a team January 2, 2024 03:14
@arielj arielj changed the title [Fix/UI] Fix status after abort. Make width more stable [Fix/UI] Fix status after aborting wine installation. Make width of progress more stable Jan 2, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I think this whole page needs a redesign and maybe we already have one on the Figma file.

@arielj arielj merged commit 76c6bca into main Jan 2, 2024
@arielj arielj deleted the wine-download-progress-fixes branch January 2, 2024 14:21
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling the installation of a Wine version does not update the status of the item

3 participants