Skip to content

Sort favourites alphabetically (#2965) #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arielj merged 2 commits into from
Dec 8, 2023
Merged

Sort favourites alphabetically (#2965) #3283

arielj merged 2 commits into from
Dec 8, 2023

Conversation

@sluedecke
Copy link
Contributor

@sluedecke sluedecke commented Dec 1, 2023

Fixes #2965

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [-] Created / Updated Tests (If necessary)
  • [-] Created / Updated documentation (If necessary)

@sluedecke sluedecke changed the title Sort favourites alphabetically (##2965) Sort favourites alphabetically (#2965) Dec 1, 2023
@flavioislima
Copy link
Member

flavioislima commented Dec 5, 2023

@sluedecke can you update the branch?
Then it will ask you to sign the CLA, just follow the instructions.

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 5, 2023
@flavioislima
Copy link
Member

flavioislima commented Dec 8, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sluedecke
Copy link
Contributor Author

sluedecke commented Dec 8, 2023

I have read the CLA Document and I hereby sign the CLA

@sluedecke
Copy link
Contributor Author

sluedecke commented Dec 8, 2023

recheck

arielj
arielj approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@arielj arielj merged commit 957846c into Heroic-Games-Launcher:main Dec 8, 2023
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima

Assignees

No one assigned

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Favourites not sorted alphabetically, in fact in somehow random order

3 participants

@sluedecke @flavioislima @arielj