[Tech] Deduplicate our Workflows #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The "install-deps" action is used to have one place to declare (common) dependencies for building - The build-base workflow is used for a generic "build Heroic for all platforms and upload the results" step (since we do that multiple times as well) - Job strategies were used wherever possible to not repeat (nearly) the same steps for 3 OSs
2e91f60 to
3caf42b
Compare
flavioislima
reviewed
Nov 5, 2023
flavioislima
requested changes
Nov 5, 2023
Member
flavioislima
left a comment
There was a problem hiding this comment.
Just change the install deps to use npm and we are fine 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flavioislima I'm assuming that we'd need to configure the repo so it no longer requires a "build" check for PRs (the equivalent file is
build-prs.ymlnow), otherwise GH will keep showing this "expected" build task that'll never actually start (since the file no longer exists)I shuffled the files around a bit since it felt unclear which file was doing what before
Use the following Checklist if you have changed something on the Backend or Frontend: