Skip to content

[GOG]: ignore pack game type #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flavioislima merged 1 commit into from
Jul 14, 2023
Merged

[GOG]: ignore pack game type #2836

flavioislima merged 1 commit into from
Jul 14, 2023

Conversation

@imLinguin
Copy link
Member

@imLinguin imLinguin commented Jul 2, 2023

This should prevent packs that are not games itself like The Incredible Machine Mega Pack from displaying in library.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 2, 2023
@imLinguin imLinguin requested review from a team, CommandMC, Nocccer, arielj and flavioislima and removed request for a team July 2, 2023 20:18
flavioislima
flavioislima approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 02ac2a1 into main Jul 14, 2023
@flavioislima flavioislima deleted the fix/gog_game_type branch July 14, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees

No one assigned

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imLinguin @flavioislima