Skip to content

Conversation

@Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jun 15, 2023

This PR makes sure that the frontend does not throw if something acces undefined object which contains is_dlc.
Every backend getGameInfo returns know an invalid GameInfo instead null.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer requested review from a team, CommandMC, arielj, flavioislima and imLinguin and removed request for a team June 15, 2023 23:47
@Nocccer Nocccer linked an issue Jun 15, 2023 that may be closed by this pull request
@arielj
Copy link
Collaborator

arielj commented Jun 20, 2023

should we change the type of .install to be possibly undefined? because if this can be undefined it would be easy to run into this issue again in the future if typescript does not warn us about it and we forget

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jun 29, 2023

should we change the type of .install to be possibly undefined? because if this can be undefined it would be easy to run into this issue again in the future if typescript does not warn us about it and we forget

I tried another approach. Maybe that fixes it aswell. If you think the undefined way is better, let me know.

@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 29, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit fba98ba into main Jun 30, 2023
@flavioislima flavioislima deleted the fix/blank_screen_becuase_dlc branch June 30, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank download page

4 participants