Chore/sick abroad deflect GEN-5133#2914
Merged
panasetskaya merged 8 commits intodevelopfrom Apr 8, 2026
Merged
Conversation
sladan-hedvig
approved these changes
Apr 8, 2026
StylianosGakis
approved these changes
Apr 8, 2026
| val content: InfoBlock, | ||
| val faq: List<InfoBlock>, | ||
| val buttonText: String, | ||
| @Contextual |
Member
There was a problem hiding this comment.
I don't actually know how this works, is it still fine with the navigation library and all?
Contributor
Author
There was a problem hiding this comment.
seems to work! IDE asked for it
| implementation(projects.composeUi) | ||
| } | ||
| androidMain.dependencies { | ||
| implementation(libs.androidx.compose.foundation) |
Member
There was a problem hiding this comment.
Without testing it, I am assuming that this should still work even without this androidMain block at all if we bring in the foundation dependency in commonMain. Did you encounter issues without it or is this just a leftover from a migration?
Contributor
Author
There was a problem hiding this comment.
I had problems with my preview and added android to plugin and this too, and it got better:) will remove dep part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sickAbroadActionwithsickAbroadDeflect, settingpreferredMinHeightto null for now