FlxCamera: make the filters array public#2890
Merged
Geokureli merged 8 commits intoHaxeFlixel:devfrom Aug 15, 2023
Sword352:camera-filters-extension
Merged
FlxCamera: make the filters array public#2890Geokureli merged 8 commits intoHaxeFlixel:devfrom Sword352:camera-filters-extension
Geokureli merged 8 commits intoHaxeFlixel:devfrom
Sword352:camera-filters-extension
Conversation
Contributor
Author
|
Might as well add functions for shaders later on since they are used a lot (by using ShaderFilter) |
Member
|
as i mention in #2888, I think we should rethink filters. if you're gonna add an add and remove function maybe we should just make this var public |
Contributor
Author
|
Yeah that make sense to just make it public, let me do a little commit |
Contributor
Author
|
Alright, the |
Geokureli
requested changes
Aug 13, 2023
Contributor
Author
|
All done |
Contributor
Author
|
Accidentally closed the pr 😅 |
Geokureli
requested changes
Aug 13, 2023
Contributor
Author
|
Done as well |
Geokureli
requested changes
Aug 13, 2023
Contributor
Author
|
Done |
Geokureli
approved these changes
Aug 13, 2023
Member
|
Sorry for the delay I had a busy weekend. Thanks for being patient, @Sword352 |
charlesisfeline
pushed a commit
to AumSum-Funkin-Team/PlutosReprisalAumSumTakeover
that referenced
this pull request
Oct 17, 2023
- Remove `FlxRuntimeShader` since Haxeflixel added `FlxRuntimeShader` HaxeFlixel/flixel-addons#399 * Migrate `FlxAnimationController` to Flixel 5.4.1 HaxeFlixel/flixel#2930 * Fix `FlxCamera.filters` Deprecation Warning HaxeFlixel/flixel#2890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add the
addFilterandremoveFilterfunctions toFlxCamera.Should be useful for many situations