Merged
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes introduce a manifest-driven, script-based dependency and service management system (format v0.1.0-beta.4), replacing inline commands with entryPoint-defined scripts (check, install, start). Results are standardized via ResultSessionFile and parsed from result.json. Redundant UI dialogs are removed, Redux state simplified, and service startup refactored to extract URL/port from script outputs. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Renderer as Renderer Process
participant Main as Main Process
participant DM as Dependency Manager
participant Script as Entry Point Script
participant FS as File System
User->>Renderer: Trigger Dependency Check
Renderer->>Main: IPC: Check Dependencies
Main->>DM: checkFromManifest(deps, entryPoint)
DM->>Script: Execute entryPoint.check
Script->>FS: Write result.json
Script-->>DM: Script completes
DM->>FS: Read result.json
FS-->>DM: ResultSessionFile
DM->>DM: Parse Results
DM-->>Main: DependencyCheckResult[]
Main-->>Renderer: IPC: Update UI with statuses
Renderer->>User: Display dependency status
sequenceDiagram
actor User
participant Renderer as Renderer Process
participant Main as Main Process
participant DM as Dependency Manager
participant Script as Entry Point Script
participant FS as File System
User->>Renderer: Install Missing Dependencies
Renderer->>Main: IPC: installFromManifest(versionId)
Main->>DM: setWorkingDirectory(path)
Main->>DM: installSingleDependency(dep, entryPoint)
DM->>Script: Execute entryPoint.install
Script->>FS: Write install-result.json
Script-->>DM: Script completes
DM->>FS: Read install-result.json
FS-->>DM: ResultSessionFile
DM->>DM: Parse Results<br/>(success, version, installHint)
DM-->>Main: InstallResult
Main-->>Renderer: IPC: Installation complete
Renderer->>User: Show success/failure + installHint
sequenceDiagram
actor User
participant Renderer as Renderer Process
participant Main as Main Process
participant WSM as Web Service Manager
participant Script as Entry Point Script
participant FS as File System
participant Service as Web Service
User->>Renderer: Start Service
Renderer->>Main: IPC: Start Service
Main->>WSM: setEntryPoint(entryPoint)
Main->>WSM: start()
WSM->>Script: Execute entryPoint.start
Script->>Service: Launch service
Script->>FS: Write result.json<br/>(url, port, etc.)
Script-->>WSM: Script completes
WSM->>FS: Read result.json
FS-->>WSM: ResultSessionFile
WSM->>WSM: Parse URL/port
WSM-->>Main: StartResult<br/>(success, url, port)
Main-->>Renderer: IPC: Service started
Renderer->>User: Display URL and ready status
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This was referenced Feb 13, 2026
Merged
This was referenced Feb 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
UI/UX Improvements