Merged
Conversation
📝 WalkthroughWalkthroughThis PR fixes an Electron white screen issue by introducing path resolution helper functions ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In
`@openspec/changes/archive/2026-02-09-fix-electron-white-screen-issue/fix-electron-white-screen-issue/specs/electron-app/spec.md`:
- Line 34: The scenario text in spec.md currently says "AppImage 或 deb 包" but
the deb target is disabled in electron-builder.yml; update the scenario in
openspec/changes/archive/2026-02-09-fix-electron-white-screen-issue/fix-electron-white-screen-issue/specs/electron-app/spec.md
to reflect only the active packaging target (e.g., change to "AppImage 包"), or
alternatively re-enable the deb target in electron-builder.yml by restoring the
deb target entry so the spec and build config match; ensure you reference the
exact phrase "AppImage 或 deb 包" when making the change.
In `@src/main/main.ts`:
- Around line 108-117: fs.access(htmlPath) is called fire-and-forget so
mainWindow.loadFile(htmlPath) proceeds regardless; either make the intent
explicit by adding a comment that the check is purely informational (leave
fs.access as-is) or gate the load by awaiting the file check and only calling
mainWindow.loadFile on success (which requires making createWindow() async and
handling the catch to log and abort/handle the failure). Update or add a comment
if you choose the informational route, or convert the fs.access promise into an
await with try/catch and call mainWindow.loadFile(htmlPath) inside the success
branch if you choose the gated route; also keep
mainWindow.webContents.openDevTools() behavior unchanged or move it after the
successful load if you want it conditional.
🧹 Nitpick comments (1)
electron-builder.yml (1)
46-47: Minor: Inconsistent comment formatting and consider removing unused targets.The commented-out targets have inconsistent spacing (
# - debvs#- tar.gz). If these targets are intentionally disabled, consider either:
- Removing them entirely if they won't be needed
- Using consistent formatting if keeping them for reference
🔧 Suggested fix for consistent formatting
- AppImage - # - deb - `#-` tar.gz + # - deb + # - tar.gz
| #### Scenario: 用户在 Linux 平台安装应用 | ||
|
|
||
| **Given** 用户使用 Linux 发行版（Ubuntu、Fedora 等） | ||
| **When** 用户下载并运行 AppImage 或 deb 包 |
There was a problem hiding this comment.
Minor inconsistency: Scenario mentions "deb 包" but deb target is disabled.
The scenario mentions "AppImage 或 deb 包" but the electron-builder.yml has commented out the deb target. Consider updating the scenario to reflect the current packaging targets (AppImage only) or re-enable deb in the build config.
🤖 Prompt for AI Agents
In
`@openspec/changes/archive/2026-02-09-fix-electron-white-screen-issue/fix-electron-white-screen-issue/specs/electron-app/spec.md`
at line 34, The scenario text in spec.md currently says "AppImage 或 deb 包" but
the deb target is disabled in electron-builder.yml; update the scenario in
openspec/changes/archive/2026-02-09-fix-electron-white-screen-issue/fix-electron-white-screen-issue/specs/electron-app/spec.md
to reflect only the active packaging target (e.g., change to "AppImage 包"), or
alternatively re-enable the deb target in electron-builder.yml by restoring the
deb target entry so the spec and build config match; ensure you reference the
exact phrase "AppImage 或 deb 包" when making the change.
Comment on lines
+108
to
117
| // Verify file exists for debugging | ||
| fs.access(htmlPath) | ||
| .then(() => console.log('[Hagicode] HTML file verified to exist')) | ||
| .catch((err) => console.error('[Hagicode] HTML file not found:', err)); | ||
|
|
||
| // Enable DevTools for production to diagnose white screen issue | ||
| // TODO: Remove this after white screen issue is resolved | ||
| mainWindow.webContents.openDevTools(); | ||
|
|
||
| mainWindow.loadFile(htmlPath); |
There was a problem hiding this comment.
The file existence check runs concurrently with loadFile() and doesn't gate the load.
The fs.access() call is fire-and-forget—its result doesn't affect whether loadFile() proceeds. If the intent is to verify the file exists before loading, the check should be awaited and the load should be conditional. As written, the verification only logs the result after the fact.
If this is intentional (just for debugging), consider adding a comment to clarify. Otherwise, consider restructuring to await the check.
🔧 Option 1: Make the check informational only (add clarifying comment)
// Verify file exists for debugging
+ // Note: This check is for logging only and doesn't block loadFile()
fs.access(htmlPath)
.then(() => console.log('[Hagicode] HTML file verified to exist'))
.catch((err) => console.error('[Hagicode] HTML file not found:', err));🔧 Option 2: Gate the load on successful verification
- // Verify file exists for debugging
- fs.access(htmlPath)
- .then(() => console.log('[Hagicode] HTML file verified to exist'))
- .catch((err) => console.error('[Hagicode] HTML file not found:', err));
-
- // Enable DevTools for production to diagnose white screen issue
- // TODO: Remove this after white screen issue is resolved
- mainWindow.webContents.openDevTools();
-
- mainWindow.loadFile(htmlPath);
+ // Verify file exists before loading
+ try {
+ await fs.access(htmlPath);
+ console.log('[Hagicode] HTML file verified to exist');
+ } catch (err) {
+ console.error('[Hagicode] HTML file not found:', err);
+ }
+
+ // Enable DevTools for production to diagnose white screen issue
+ // TODO: Remove this after white screen issue is resolved
+ mainWindow.webContents.openDevTools();
+
+ mainWindow.loadFile(htmlPath);Note: This would require making createWindow() async.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Verify file exists for debugging | |
| fs.access(htmlPath) | |
| .then(() => console.log('[Hagicode] HTML file verified to exist')) | |
| .catch((err) => console.error('[Hagicode] HTML file not found:', err)); | |
| // Enable DevTools for production to diagnose white screen issue | |
| // TODO: Remove this after white screen issue is resolved | |
| mainWindow.webContents.openDevTools(); | |
| mainWindow.loadFile(htmlPath); | |
| // Verify file exists for debugging | |
| // Note: This check is for logging only and doesn't block loadFile() | |
| fs.access(htmlPath) | |
| .then(() => console.log('[Hagicode] HTML file verified to exist')) | |
| .catch((err) => console.error('[Hagicode] HTML file not found:', err)); | |
| // Enable DevTools for production to diagnose white screen issue | |
| // TODO: Remove this after white screen issue is resolved | |
| mainWindow.webContents.openDevTools(); | |
| mainWindow.loadFile(htmlPath); |
🤖 Prompt for AI Agents
In `@src/main/main.ts` around lines 108 - 117, fs.access(htmlPath) is called
fire-and-forget so mainWindow.loadFile(htmlPath) proceeds regardless; either
make the intent explicit by adding a comment that the check is purely
informational (leave fs.access as-is) or gate the load by awaiting the file
check and only calling mainWindow.loadFile on success (which requires making
createWindow() async and handling the catch to log and abort/handle the
failure). Update or add a comment if you choose the informational route, or
convert the fs.access promise into an await with try/catch and call
mainWindow.loadFile(htmlPath) inside the success branch if you choose the gated
route; also keep mainWindow.webContents.openDevTools() behavior unchanged or
move it after the successful load if you want it conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores