Add error checking to zstd hdf5 plugin - #280
Open
pimlu wants to merge 1 commit into
Open
Conversation
This PR adds error checking to the zstd hdf5 plugin. Previously it would return uninitialized memory from malloc when any zstd error occurred. It also prevents proceeding with the result of malloc(0) in the abnormal case where decompSize == 0.
pimlu
commented
Jul 30, 2026
| @@ -66,10 +66,16 @@ H5Z_filter_zstd(unsigned int flags, size_t cd_nelmts, const unsigned int cd_valu | |||
| if (flags & H5Z_FLAG_REVERSE) { | |||
| /* We're decompressing */ | |||
| size_t decompSize = ZSTD_getFrameContentSize(*buf, origSize); | |||
Author
There was a problem hiding this comment.
Technically decompSize should be an unsigned long long but on 64-bit systems the outcome is the same. Let me know if I should update this in the same PR.
Collaborator
There was a problem hiding this comment.
Please fix that here.
Below, an unknown content size should not be treated as an error. That is a perfectly valid situation for Zstandard compressed data.
We may need to use the streaming API to complete decompression, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds error checking to the zstd hdf5 plugin. Previously it would return uninitialized memory from malloc when any zstd error occurred.
It also prevents proceeding with the result of
malloc(0)in the abnormal case wheredecompSize == 0.