Skip to content

improvement: if social card not found, try to retrieve length from remote URL#225

Merged
Guts merged 1 commit intomainfrom
feature/get-lentgth-from-remote-social-cards-if-local-still-not-present-at-build-time
Dec 17, 2023
Merged

improvement: if social card not found, try to retrieve length from remote URL#225
Guts merged 1 commit intomainfrom
feature/get-lentgth-from-remote-social-cards-if-local-still-not-present-at-build-time

Conversation

@Guts
Copy link
Copy Markdown
Owner

@Guts Guts commented Dec 17, 2023

If the social card has been previously published, it works.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2023

Codecov Report

Merging #225 (132f9a9) into main (e505ce2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files          10       10           
  Lines         524      524           
  Branches      108      108           
=======================================
  Hits          440      440           
  Misses         53       53           
  Partials       31       31           
Files Coverage Δ
mkdocs_rss_plugin/util.py 72.76% <100.00%> (ø)

@Guts Guts self-assigned this Dec 17, 2023
@Guts Guts added the enhancement New feature or request label Dec 17, 2023
@Guts Guts merged commit 93564f4 into main Dec 17, 2023
@Guts Guts deleted the feature/get-lentgth-from-remote-social-cards-if-local-still-not-present-at-build-time branch December 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant