chore: update datafusion family#6675
Conversation
be39d93 to
3fb6a98
Compare
09c95e4 to
b781652
Compare
4cc235b to
24e0466
Compare
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
12d70e3 to
3f535cf
Compare
3f535cf to
7c4a552
Compare
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
1cd0b77 to
d28a7e6
Compare
discord9
left a comment
There was a problem hiding this comment.
LGTM, but I think we need a way to keep track of those sqlness result change and resolve them later
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DataFusion family of dependencies, including Arrow (54→56), DataFusion (months ago→day 8.12), Tonic (0.12→0.13), and SQLParser (0.54→0.55). The changes primarily involve updating test expectations to align with new query execution plans and output formats introduced by the updated dependencies.
- Updates dependency versions for Arrow, DataFusion, Tonic, and SQLParser
- Adjusts test files to account for new query plan structures and output formats
- Fixes compatibility issues with updated DataFusion query optimizer and execution engine
Reviewed Changes
Copilot reviewed 196 out of 198 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cases/standalone/tql-explain-analyze/analyze.sql | Adds SQLNESS REPLACE directive for Hash patterns |
| tests/cases/standalone/tql-explain-analyze/analyze.result | Updates query execution plans to include CooperativeExec nodes and additional execution operators |
| tests/cases/standalone/optimizer/*.result | Updates query plans to reflect new DataFusion execution structure with CooperativeExec wrapping |
| tests/cases/standalone/common/types/string/unicode.sql | Adds CAST workaround for Utf8View compatibility issue |
| tests/cases/standalone/common/types/timestamp/timestamp.result | Updates error message format to include quotes around error details |
| tests/cases/standalone/common/tql/range.sql | Quotes 'service' column name as reserved keyword |
| tests/cases/standalone/optimizer/filter_push_down.sql | Removes TODO comments and aligns results with PostgreSQL behavior |
| tests/cases/distributed/*.result | Similar execution plan updates for distributed test cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Can we confirm if there is any user space breaking change? |
|
@sunng87 I can think of two minor ones:
|
* chore: update datafusion family Signed-off-by: luofucong <luofc@foxmail.com> * fix ci Signed-off-by: luofucong <luofc@foxmail.com> * use official otel-arrow-rust Signed-off-by: luofucong <luofc@foxmail.com> * rebase Signed-off-by: luofucong <luofc@foxmail.com> * use the official orc-rust Signed-off-by: luofucong <luofc@foxmail.com> * resolve PR comments Signed-off-by: luofucong <luofc@foxmail.com> * remove the empty lines Signed-off-by: luofucong <luofc@foxmail.com> * try following PR comments Signed-off-by: luofucong <luofc@foxmail.com> --------- Signed-off-by: luofucong <luofc@foxmail.com> Signed-off-by: codephage2020 <tingwangyan2020@163.com>
pass clippy and fmt
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
most notably updates are:
arrow 54 -> 56
datafusion months ago to day 8.12
tonic 0.12 -> 0.13
sqlparser 0.54 -> 0.55
PR Checklist
Please convert it to a draft if some of the following conditions are not met.