fix: cap sort preserving merge statistics by fetch - #13
Merged
waynexia merged 1 commit intoJul 7, 2026
Conversation
waynexia
approved these changes
Jul 7, 2026
waynexia
merged commit Jul 7, 2026
2951f82
into
GreptimeTeam:greptimedb-53.1.0-function-signature-exec-error
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SortPreservingMergeExecstatistics by itsfetchlimit so top-k/scalar sides expose their small row count to physical optimizersJoinSelectionswapping an SPM(fetch=1) side to the hash join build sideTesting
cargo test -p datafusion-common test_with_fetchcargo test -p datafusion-physical-plan sort_preserving_mergecargo test -p datafusion join_selection --test core_integrationcargo check -p datafusion --test core_integrationcargo fmt --all -- --checkNotes
cargo clippy --all-targets --all-features -- -D warningscurrently fails on unrelated existing 53-branch lints indatafusion/common/src/hash_utils.rs,pruning.rs,scalar/mod.rs, anderror.rs; this patch does not touch those files.