Skip to content

Add skilling tests and fixes#945

Merged
GregHib merged 12 commits intomainfrom
skilling-tests
Apr 10, 2026
Merged

Add skilling tests and fixes#945
GregHib merged 12 commits intomainfrom
skilling-tests

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Apr 10, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 32.69231% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.78%. Comparing base (201eb44) to head (fc914bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/content/area/asgarnia/falador/farm/Sarah.kt 6.45% 29 Missing ⚠️
...gs/voidps/engine/data/definition/NPCDefinitions.kt 5.26% 17 Missing and 1 partial ⚠️
...tent/area/misthalin/barbarian_village/Barbarian.kt 20.00% 8 Missing ⚠️
...rc/main/kotlin/content/entity/world/music/Music.kt 44.44% 4 Missing and 1 partial ⚠️
...area/misthalin/barbarian_village/TassieSlipcast.kt 40.00% 3 Missing ⚠️
...in/kotlin/content/minigame/barrows/BarrowsChest.kt 75.00% 0 Missing and 2 partials ⚠️
.../src/main/kotlin/content/skill/crafting/Weaving.kt 71.42% 1 Missing and 1 partial ⚠️
...n/kotlin/content/minigame/barrows/BarrowsCrypts.kt 80.00% 0 Missing and 1 partial ⚠️
.../src/main/kotlin/content/skill/crafting/Pottery.kt 0.00% 0 Missing and 1 partial ⚠️
...n/kotlin/content/skill/prayer/bone/BoneOffering.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../world/gregs/voidps/engine/client/ui/Interfaces.kt 61.42% <ø> (+0.43%) ⬆️
game/src/main/kotlin/content/entity/npc/Sheep.kt 21.05% <100.00%> (ø)
...ain/kotlin/content/skill/crafting/SpinningWheel.kt 51.28% <ø> (+31.28%) ⬆️
...e/src/main/kotlin/content/skill/crafting/Thread.kt 90.00% <100.00%> (+67.77%) ⬆️
...n/kotlin/content/minigame/barrows/BarrowsCrypts.kt 58.33% <80.00%> (+7.38%) ⬆️
.../src/main/kotlin/content/skill/crafting/Pottery.kt 42.00% <0.00%> (+38.00%) ⬆️
...n/kotlin/content/skill/prayer/bone/BoneOffering.kt 64.00% <0.00%> (+56.00%) ⬆️
...in/kotlin/content/minigame/barrows/BarrowsChest.kt 77.96% <75.00%> (+11.86%) ⬆️
.../src/main/kotlin/content/skill/crafting/Weaving.kt 52.83% <71.42%> (+48.83%) ⬆️
...area/misthalin/barbarian_village/TassieSlipcast.kt 40.00% <40.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #945      +/-   ##
============================================
+ Coverage     37.64%   37.78%   +0.14%     
- Complexity     8076     8098      +22     
============================================
  Files          1668     1671       +3     
  Lines         66883    66945      +62     
  Branches      16698    16719      +21     
============================================
+ Hits          25179    25297     +118     
+ Misses        36083    35988      -95     
- Partials       5621     5660      +39     
Components Coverage Δ
Content 35.85% <38.82%> (+0.22%) ⬆️
Engine 45.30% <5.26%> (-0.05%) ⬇️
Network 60.26% <ø> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 0895a10 into main Apr 10, 2026
5 checks passed
@GregHib GregHib deleted the skilling-tests branch April 10, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Music tracks not changing between regions Add looms Add missing tests for skills

1 participant