Do not add a dependencies block if it's already there#769
Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom Jul 20, 2022
Merged
Do not add a dependencies block if it's already there#769johnrengelman merged 1 commit intoGradleUp:masterfrom
johnrengelman merged 1 commit intoGradleUp:masterfrom
Conversation
Sometimes the publication already has a pom, so adding a node will result in a duplicated dependencies block
|
This is just what I was looking for! Do snapshots of the plugin get published that I can use pre-release? |
Contributor
Contributor
|
Fixed in #791 |
Contributor
This PR just reverts the behavior as it was prior to the conflicting commit. |
Contributor
|
Exactly. But since this PR broke the lib, it is better to revert rather than leave it as is. |
Contributor
|
PR #798 fixes the issue in a correct way by avoiding duplicate dependencies nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the publication already has a pom, so adding a node will result in a duplicated dependencies block