Stop using start script templates bundled in Shadow

src/docs/changes/README.md

@@ -3,6 +3,10 @@
 
 ## [Unreleased]
 
+**Changed**
+
+- Stop using start script templates bundled in Shadow. ([#1750](https://github.com/GradleUp/shadow/pull/1750))
+
 **Fixed**
 
 - Fix resolving BOM dependencies when `minimize` is enabled. ([#1638](https://github.com/GradleUp/shadow/pull/1638))

src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.groovy

@@ -79,8 +79,6 @@ class ShadowApplicationPlugin implements Plugin<Project> {
 
     protected void addCreateScriptsTask(Project project) {
         project.tasks.register(SHADOW_SCRIPTS_TASK_NAME, CreateStartScripts) { startScripts ->
-            startScripts.unixStartScriptGenerator.template = project.resources.text.fromString(this.class.getResource("internal/unixStartScript.txt").text)
-            startScripts.windowsStartScriptGenerator.template = project.resources.text.fromString(this.class.getResource("internal/windowsStartScript.txt").text)
             startScripts.description = 'Creates OS specific scripts to run the project as a JVM application using the shadow jar'
             startScripts.group = ApplicationPlugin.APPLICATION_GROUP
             startScripts.classpath = project.files(jar)

src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy

@@ -32,11 +32,11 @@ class ApplicationSpec extends PluginSpecification {
             application {
                mainClass = 'myapp.Main'
             }
-            
+
             dependencies {
                implementation 'shadow:a:1.0'
             }
-            
+
             runShadow {
                args 'foo'
             }
@@ -66,7 +66,6 @@ class ApplicationSpec extends PluginSpecification {
         File startScript = getFile('build/install/myapp-shadow/bin/myapp')
         assert startScript.exists()
         assert startScript.text.contains("CLASSPATH=\$APP_HOME/lib/myapp-1.0-all.jar")
-        assert startScript.text.contains("-jar \"\\\"\$CLASSPATH\\\"\" \"\$APP_ARGS\"")
         assert startScript.text.contains("exec \"\$JAVACMD\" \"\$@\"")
 
         cleanup:
@@ -91,35 +90,35 @@ class ApplicationSpec extends PluginSpecification {
 
         buildFile << """
             apply plugin: 'application'
-            
+
             application {
                mainClass = 'myapp.Main'
             }
-            
+
             dependencies {
                implementation 'shadow:a:1.0'
             }
-            
+
             java {
                 toolchain {
                     languageVersion = JavaLanguageVersion.of(17)
                 }
             }
-            
+
             runShadow {
                args 'foo'
                doFirst {
                    logger.lifecycle("Running application with JDK \${it.javaLauncher.get().metadata.languageVersion.asInt()}")
                }
-            }          
+            }
         """.stripIndent()
 
-        settingsFile.write """ 
+        settingsFile.write """
             plugins {
               // https://docs.gradle.org/8.0.1/userguide/toolchains.html#sub:download_repositories
               id("org.gradle.toolchains.foojay-resolver-convention") version("0.7.0")
             }
-            
+
             rootProject.name = 'myapp'
         """.stripIndent()
 
@@ -146,7 +145,6 @@ class ApplicationSpec extends PluginSpecification {
         File startScript = getFile('build/install/myapp-shadow/bin/myapp')
         assert startScript.exists()
         assert startScript.text.contains("CLASSPATH=\$APP_HOME/lib/myapp-1.0-all.jar")
-        assert startScript.text.contains("-jar \"\\\"\$CLASSPATH\\\"\" \"\$APP_ARGS\"")
         assert startScript.text.contains("exec \"\$JAVACMD\" \"\$@\"")
 
         cleanup:
@@ -176,11 +174,11 @@ class ApplicationSpec extends PluginSpecification {
             application {
                mainClass = 'myapp.Main'
             }
-            
+
             dependencies {
                shadow 'shadow:a:1.0'
             }
-            
+
             runShadow {
                args 'foo'
             }
@@ -228,11 +226,11 @@ class ApplicationSpec extends PluginSpecification {
             application {
                mainClass = 'myapp.Main'
             }
-            
+
             dependencies {
                implementation 'shadow:a:1.0'
             }
-            
+
             runShadow {
                args 'foo'
             }