Honor executableDir and applicationName in application extension#1740
Merged
Honor executableDir and applicationName in application extension#1740
executableDir and applicationName in application extension#1740Conversation
7a3fb19 to
e8c37e0
Compare
e8c37e0 to
e26b456
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the shadow plugin to properly honor the applicationName property from the application extension, building on the previous work to honor executableDir. The changes ensure that when users configure a custom application name, it's consistently used throughout the shadow distribution process.
- Updates distribution configuration to use custom application name in base name
- Refactors provider usage for better consistency with method references
- Adds comprehensive test coverage for both applicationName and executableDir properties
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShadowApplicationPlugin.kt | Updates distribution configuration to honor applicationName and refactors provider usage |
| ApplicationPluginTest.kt | Adds test coverage for applicationName and executableDir extension properties |
| README.md | Updates changelog to document the new applicationName support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
applicationName in application extensionexecutableDir and applicationName in application extension
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #1738.