Skip to content

Honor executableDir and applicationName in application extension#1740

Merged
Goooler merged 8 commits intomainfrom
g/20250914/distributionBaseName
Sep 15, 2025
Merged

Honor executableDir and applicationName in application extension#1740
Goooler merged 8 commits intomainfrom
g/20250914/distributionBaseName

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Sep 14, 2025

Follow up #1738.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler force-pushed the g/20250914/distributionBaseName branch 2 times, most recently from 7a3fb19 to e8c37e0 Compare September 14, 2025 11:54
@Goooler Goooler force-pushed the g/20250914/distributionBaseName branch from e8c37e0 to e26b456 Compare September 14, 2025 11:56
@Goooler Goooler requested a review from Copilot September 15, 2025 02:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the shadow plugin to properly honor the applicationName property from the application extension, building on the previous work to honor executableDir. The changes ensure that when users configure a custom application name, it's consistently used throughout the shadow distribution process.

  • Updates distribution configuration to use custom application name in base name
  • Refactors provider usage for better consistency with method references
  • Adds comprehensive test coverage for both applicationName and executableDir properties

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ShadowApplicationPlugin.kt Updates distribution configuration to honor applicationName and refactors provider usage
ApplicationPluginTest.kt Adds test coverage for applicationName and executableDir extension properties
README.md Updates changelog to document the new applicationName support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Goooler Goooler changed the title Honor applicationName in application extension Honor executableDir and applicationName in application extension Sep 15, 2025
@Goooler Goooler enabled auto-merge (squash) September 15, 2025 02:29
@Goooler Goooler merged commit cb6ed4c into main Sep 15, 2025
9 of 10 checks passed
@Goooler Goooler deleted the g/20250914/distributionBaseName branch September 15, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant