Fail build if the ZIP entries in the shadowed JAR are duplicate#1552
Merged
Fail build if the ZIP entries in the shadowed JAR are duplicate#1552
Conversation
5ff798e to
157f2f4
Compare
…ks/ShadowCopyAction.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new feature to fail the build if duplicate ZIP entries are found in the shadowed JAR, addressing issue #1551. This provides a more strict duplicate detection mechanism compared to the existing duplicatesStrategy option.
- Adds
failOnDuplicateEntriesproperty toShadowJartask with CLI support - Implements duplicate entry detection logic in
ShadowCopyAction - Updates documentation and adds comprehensive test coverage
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ShadowJar.kt | Adds new failOnDuplicateEntries property and passes it to ShadowCopyAction |
| ShadowCopyAction.kt | Implements duplicate entry detection and adds extension for accessing ZIP entries |
| RelocationTest.kt | Improves parameter naming for clarity |
| JavaPluginTest.kt | Adds comprehensive tests for the new duplicate detection feature |
| Documentation files | Updates CLI options documentation and changelog |
| shadow.api | Updates API signature to reflect new parameter |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1551.