Note the latest snapshot versions #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Getting Started guide by pointing users to the VERSION_NAME property for snapshot versions.
- Adds comments in both Kotlin and Groovy DSL snippets to reference the snapshot version defined in
gradle.properties.
Comments suppressed due to low confidence (2)
docs/getting-started/README.md:71
- [nitpick] Consider converting the plain URL into a markdown link for better readability, e.g.:
// You can get the latest snapshot version from `VERSION_NAME` declared in [gradle.properties](https://github.com/GradleUp/shadow/blob/main/gradle.properties)
// You can get the latest snapshot version from `VERSION_NAME` declared in https://github.com/GradleUp/shadow/blob/main/gradle.properties
docs/getting-started/README.md:97
- [nitpick] Similarly, update this comment to use a clickable markdown link for consistency and clarity, for example:
// You can get the latest snapshot version from `VERSION_NAME` declared in [gradle.properties](https://github.com/GradleUp/shadow/blob/main/gradle.properties)
// You can get the latest snapshot version from `VERSION_NAME` declared in https://github.com/GradleUp/shadow/blob/main/gradle.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1426 (comment).