This repository was archived by the owner on Jun 3, 2025. It is now read-only.
hack/boilerplate.sh: fix error handling and use python3#2587
Merged
aaron-prindle merged 2 commits intoJun 20, 2023
Conversation
python2 is no longer included in most distros and will be removed from Github Actions Ubuntu images: actions/runner-images#7402
aaron-prindle
approved these changes
Jun 20, 2023
aaron-prindle
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR @andreasf! LGTM
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
…nerTools#2587) * hack/boilerplate.sh: fix successful return code when call to python fails * hack/boilerplate.sh: update to python3 python2 is no longer included in most distros and will be removed from Github Actions Ubuntu images: actions/runner-images#7402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2586
Description
This fixes error handling in
hack/boilerplate.shand callsboilerplate.pywithpython3instead ofpython.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes