fix(storage): skip test temporarily before pap changes release #6750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unforced
approved these changes
Sep 27, 2021
dandhlee
approved these changes
Sep 27, 2021
Collaborator
dandhlee
left a comment
There was a problem hiding this comment.
LGTM. Please add a # TODO: comment or simply add a note on the referenced issue to ensure reverting this back just for better record tracking once the release rolls out fully!
Contributor
Author
|
Added a note to the referenced issue, thanks! |
unforced
pushed a commit
to unforced/python-docs-samples
that referenced
this pull request
Sep 29, 2021
unforced
pushed a commit
that referenced
this pull request
Oct 4, 2021
* fix: update samples for pap, unspecified->inherited * restore original unspecified while adding new inherited * woops, missed a place * remove test skip #6750 * lint fix * oops * Update storage/cloud-client/storage_set_public_access_prevention_inherited.py Co-authored-by: cojenco <[email protected]> * add top level comment * move comment above regionalization tag * update version * change over unspecified test to inherited * this one too * skip inconsistent tests Co-authored-by: cojenco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporary skips failing test until we get the PAP changes for #6751 fully merged in.
GCS is changing the
unspecifiedpublic access prevention value toinheritedPlease see nodejs example here: https://github.com/googleapis/nodejs-storage/pull/1614/files