Add kms/attestations/ directory with sample script to verify attestations#3262
Merged
tmatsuo merged 2 commits intoGoogleCloudPlatform:masterfrom May 1, 2020
bkuang:master
Merged
Add kms/attestations/ directory with sample script to verify attestations#3262tmatsuo merged 2 commits intoGoogleCloudPlatform:masterfrom bkuang:master
tmatsuo merged 2 commits intoGoogleCloudPlatform:masterfrom
bkuang:master
Conversation
|
/assign |
mdlinville
reviewed
Apr 2, 2020
mdlinville
left a comment
There was a problem hiding this comment.
Please also get technical review. :)
tmatsuo
reviewed
Apr 6, 2020
tmatsuo
reviewed
Apr 9, 2020
tmatsuo
approved these changes
Apr 20, 2020
Contributor
|
In case you don't have access to the logs: Pytho builds failed with: I think you have to rebase to github master. |
tmatsuo
suggested changes
Apr 29, 2020
Contributor
tmatsuo
left a comment
There was a problem hiding this comment.
Sorry I didn't point it out in the first pass, but I think it is harmful to completely swallow exceptions.
tmatsuo
approved these changes
May 1, 2020
busunkim96
pushed a commit
to busunkim96/python-kms
that referenced
this pull request
Jun 16, 2020
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
busunkim96
pushed a commit
to busunkim96/python-kms
that referenced
this pull request
Jun 16, 2020
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 16, 2020
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
…ions [(#3262)](#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262) Co-authored-by: Benson Kuang <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a kms/attestations/ directory to hold code samples that deal with attestations and certificates obtained from Cloud HSM. This also adds a verify_attestation.py script to verify attestations using certificate bundles containing one or more certificates.
fixes #3246