Skip to content

correct GOOGLE_TEST_DIRECTORY type for VCR recording#9724

Merged
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
shuyama1:fix_vcr_list
Dec 28, 2023
Merged

correct GOOGLE_TEST_DIRECTORY type for VCR recording#9724
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
shuyama1:fix_vcr_list

Conversation

@shuyama1

@shuyama1 shuyama1 commented Dec 28, 2023

Copy link
Copy Markdown
Member

#9722 introduced an error in VCR recording - tests will only be rerun in the first service package. see #9723

This corrects the type of GOOGLE_TEST_DIRECTORY

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 61
Passed tests 57
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages
  • cloudbuild
  • cloudrunv2

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_disable|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudBuildTrigger_basic[Debug log]
TestAccCloudBuildTrigger_disable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@shuyama1 shuyama1 requested a review from slevenick December 28, 2023 19:14
@shuyama1

Copy link
Copy Markdown
Member Author

already deleted the cassettes recorded for testing

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 removed the request for review from slevenick December 28, 2023 20:10
@shuyama1 shuyama1 merged commit 2f89bb1 into GoogleCloudPlatform:main Dec 28, 2023
@shuyama1 shuyama1 deleted the fix_vcr_list branch December 28, 2023 20:10
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
…form#9724)

* fix VCR recording for multi services

* revert changes in tests
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
…form#9724)

* fix VCR recording for multi services

* revert changes in tests
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…form#9724)

* fix VCR recording for multi services

* revert changes in tests
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…form#9724)

* fix VCR recording for multi services

* revert changes in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants