Skip to content

Temporary fix for TGC tests#9116

Merged
c2thorn merged 3 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-tgc-fix
Sep 28, 2023
Merged

Temporary fix for TGC tests#9116
c2thorn merged 3 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-tgc-fix

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 28, 2023

Copy link
Copy Markdown
Member

labels - don't know if this is a proper fix, but it stops the error for now.
other tests - these fail due to the schema change from list to Set, I've just moved these to the "ignore" folder.

I've just moved all failing to the "ignore" folder.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 25 files changed, 28 insertions(+), 1675 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2781
Skipped tests: 313
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 57 files changed, 5973 deletions(-))

@c2thorn c2thorn merged commit d7c4745 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Sep 28, 2023
@c2thorn c2thorn deleted the 5.0.0-tgc-fix branch September 28, 2023 16:34
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2783
Skipped tests: 313
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

c2thorn added a commit to c2thorn/magic-modules that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants