Skip to content

Container cluster upgrade guide pt 3#9087

Merged
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
c2thorn:5.0.0-container-guide
Sep 28, 2023
Merged

Container cluster upgrade guide pt 3#9087
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
c2thorn:5.0.0-container-guide

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

upgrade guide for #9013

Release Note Template for Downstream PRs (will be copied)

@c2thorn c2thorn mentioned this pull request Sep 26, 2023
Merged
@modular-magician

modular-magician commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 36 insertions(+))
Terraform Beta: Diff ( 1 file changed, 36 insertions(+))

melinath
melinath approved these changes Sep 26, 2023
View reviewed changes
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
**`deletion_protection` does NOT prevent deletion outside of Terraform.**
To destroy a `google_container_cluster`, this field must be explicitly set to `false`.

### `networking_mode` defaults to `VPC_NATIVE` for newly created clusters

@melinath melinath Sep 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this section a bit hard to parse but I'm not sure how to improve it; the change looks complex.

@c2thorn c2thorn Sep 26, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this section for now, as it has not been approved yet.

This was referenced Sep 26, 2023
Merged
Merged
Merged
Merged
c2thorn and others added 2 commits September 26, 2023 17:25
@c2thorn
Update version_5_upgrade.html.markdown
0df473e
@c2thorn @melinath
Update mmv1/third_party/terraform/website/docs/guides/version_5_upgra…
4482f19 
…de.html.markdown

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician

modular-magician commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 7 insertions(+))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+))

@c2thorn c2thorn merged commit fd6b70a into GoogleCloudPlatform:main Sep 28, 2023
This was referenced Sep 28, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath melinath approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c2thorn @modular-magician @melinath