5.0.0 - remove computed keys from JSON in monitoring dashboard#9065
Merged
c2thorn merged 1 commit intoSep 26, 2023
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
5 tasks
36eb8fd to
323fbf2
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 10 deletions(-)) |
Collaborator
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerNodePool_withSandboxConfig |
Collaborator
|
Rerun these tests in REPLAYING mode to catch issues
|
slevenick
reviewed
Sep 25, 2023
This was referenced Sep 25, 2023
slevenick
approved these changes
Sep 26, 2023
262bbe6
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
This was referenced Sep 28, 2023
Merged
etruong42
added a commit
to etruong42/magic-modules
that referenced
this pull request
Nov 28, 2023
GoogleCloudPlatform#9065)" This reverts commit 262bbe6. That commit introduced the issue at hashicorp/terraform-provider-google#16439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebasing #5595
fixes hashicorp/terraform-provider-google#7242
upgrade guide: #8970
Release Note Template for Downstream PRs (will be copied)