Skip to content

Change consumer_accept_lists to a set#9058

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-service-attachment
Sep 25, 2023
Merged

Change consumer_accept_lists to a set#9058
c2thorn merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-service-attachment

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 22, 2023

Copy link
Copy Markdown
Member

fixes hashicorp/terraform-provider-google#12409

upgrade guide: #9059

Release Note Template for Downstream PRs (will be copied)

compute: retyped `consumer_accept_lists` to a SET from an ARRAY type for `google_compute_service_attachment

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field consumer_accept_lists changed from TypeList to TypeSet on google_compute_service_attachment - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 24 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 1 file changed, 24 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3073
Passed tests 2760
Skipped tests: 306
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccContainerNodePool_withSandboxConfig

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withSandboxConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from ScottSuarez September 23, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants