Skip to content

Labels compute instance template#9051

Merged
zli82016 merged 3 commits into
FEATURE-BRANCH-major-release-5.0.0from
labels-compute-instance-template
Sep 25, 2023
Merged

Labels compute instance template#9051
zli82016 merged 3 commits into
FEATURE-BRANCH-major-release-5.0.0from
labels-compute-instance-template

Conversation

@zli82016

@zli82016 zli82016 commented Sep 22, 2023

Copy link
Copy Markdown
Member
  1. Apply the labels model to google_compute_instance_template and google_compute_region_instance_template
  2. Make labels field have all of labels for the data sources google_compute_instance_template and google_compute_region_instance_template
  3. Add out of band labels test
  4. Modify the labels/annotations field doc to add notes

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 force-pushed the labels-compute-instance-template branch 2 times, most recently from 2d25450 to 79633d5 Compare September 22, 2023 17:55
@shuyama1 shuyama1 force-pushed the FEATURE-BRANCH-major-release-5.0.0 branch from 6374511 to 83df041 Compare September 22, 2023 17:58
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 1996 insertions(+), 87 deletions(-))
Terraform Beta: Diff ( 21 files changed, 1996 insertions(+), 87 deletions(-))
TF Conversion: Diff ( 2 files changed, 367 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@zli82016 zli82016 force-pushed the labels-compute-instance-template branch from 79633d5 to 3da03ff Compare September 22, 2023 18:55
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 86 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 5 files changed, 91 insertions(+), 32 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3073
Passed tests 2626
Skipped tests: 306
Affected tests: 141

Action taken

Found 141 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccComputeRegionAutoscaler_update|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeRegionInstanceTemplate_queueCount|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_shieldedVmConfig1|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeRegionInstanceTemplate_reservationAffinities|TestAccComputeRegionInstanceTemplate_diskIops|TestAccComputeRegionInstanceTemplate_instanceResourcePolicies|TestAccComputeRegionInstanceTemplate_spot_maxRunDuration|TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities|TestAccComputeRegionInstanceTemplate_spot|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_enableDisplay|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_versions|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_shieldedVmConfig2|TestAccRegionInstanceGroupManager_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccRegionInstanceGroupManager_basic|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_networkIPAddress|TestAccComputeRegionInstanceTemplate_networkIP|TestAccComputeRegionInstanceTemplate_networkTier|TestAccComputeRegionInstanceTemplate_IPv6|TestAccComputeRegionInstanceTemplate_IP|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeRegionInstanceTemplate_preemptible|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeInstanceTemplate_spot_maxRunDuration|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_spot|TestAccComputeInstanceTemplate_queueCount|TestAccComputeInstanceTemplate_enableDisplay|TestAccComputeInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_instanceResourcePolicies|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_IPv6|TestAccComputeInstanceTemplate_diskIops|TestAccComputeInstanceTemplate_networkIPAddress|TestAccInstanceGroupManager_waitForStatus|TestAccComputeInstanceTemplate_IP|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_stateful|TestAccComputeInstanceTemplate_regionDisks|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_versions|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_basic|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scaleInControl|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeBackendService_withMaxConnections|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_multicondition|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccRegionInstanceTemplateDatasource_filter_mostRecent|TestAccRegionInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_self_link_unique|TestAccRegionInstanceTemplateDatasource_name|TestAccComputeBackendService_withBackend|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceTemplateDatasource_name|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeBackendService_withBackendAndMaxUtilization[Error message] [Debug log]
TestAccComputeBackendService_withBackendAndIAP[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript[Error message] [Debug log]
TestAccComputeRegionAutoscaler_update[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_queueCount[Error message] [Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Error message] [Debug log]
TestAccComputeRegionPerInstanceConfig_update[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_with18TbScratchDisk[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_shieldedVmConfig1[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_withScratchDisk[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_reservationAffinities[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_diskIops[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_instanceResourcePolicies[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_spot_maxRunDuration[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_spot[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_minCpuPlatform[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_enableDisplay[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_guestAccelerator[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures[Error message] [Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_primaryAliasIpRange[Error message] [Debug log]
TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccRegionInstanceGroupManager_versions[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_metadata_startup_script[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_shieldedVmConfig2[Error message] [Debug log]
TestAccRegionInstanceGroupManager_update[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Error message] [Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_subnet_auto[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_subnet_custom[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Error message] [Debug log]
TestAccRegionInstanceGroupManager_basic[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_regionDisks[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_networkIPAddress[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_networkIP[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_networkTier[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_IPv6[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_IP[Error message] [Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_preemptible[Error message] [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Error message] [Debug log]
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputePerInstanceConfig_statefulIps[Error message] [Debug log]
TestAccComputePerInstanceConfig_update[Error message] [Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration[Error message] [Debug log]
TestAccComputeInstanceTemplate_NetworkAttachment[Error message] [Debug log]
TestAccComputeInstanceTemplate_spot[Error message] [Debug log]
TestAccComputeInstanceTemplate_queueCount[Error message] [Debug log]
TestAccComputeInstanceTemplate_enableDisplay[Error message] [Debug log]
TestAccComputeInstanceTemplate_localSsdRecoveryTimeout[Error message] [Debug log]
TestAccComputeInstanceTemplate_AdvancedMachineFeatures[Error message] [Debug log]
TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain[Error message] [Debug log]
TestAccComputeInstanceTemplate_shieldedVmConfig2[Error message] [Debug log]
TestAccComputeInstanceTemplate_shieldedVmConfig1[Error message] [Debug log]
TestAccComputeInstanceTemplate_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeInstanceTemplate_guestAcceleratorSkip[Error message] [Debug log]
TestAccComputeInstanceTemplate_reservationAffinities[Error message] [Debug log]
TestAccComputeInstanceTemplate_guestAccelerator[Error message] [Debug log]
TestAccComputeInstanceTemplate_with18TbScratchDisk[Error message] [Debug log]
TestAccComputeInstanceTemplate_primaryAliasIpRange[Error message] [Debug log]
TestAccComputeInstanceTemplate_minCpuPlatform[Error message] [Debug log]
TestAccComputeInstanceTemplate_instanceResourcePolicies[Error message] [Debug log]
TestAccComputeInstanceTemplate_secondaryAliasIpRange[Error message] [Debug log]
TestAccComputeInstanceTemplate_withScratchDisk[Error message] [Debug log]
TestAccComputeInstanceTemplate_metadata_startup_script[Error message] [Debug log]
TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey[Error message] [Debug log]
TestAccComputeInstanceTemplate_sourceImageEncryptionKey[Error message] [Debug log]
TestAccComputeInstanceTemplate_subnet_auto[Error message] [Debug log]
TestAccComputeInstanceTemplate_preemptible[Error message] [Debug log]
TestAccComputeInstanceTemplate_networkIP[Error message] [Debug log]
TestAccComputeInstanceTemplate_subnet_custom[Error message] [Debug log]
TestAccComputeInstanceTemplate_disks[Error message] [Debug log]
TestAccComputeInstanceTemplate_networkTier[Error message] [Debug log]
TestAccComputeInstanceTemplate_IPv6[Error message] [Debug log]
TestAccComputeInstanceTemplate_diskIops[Error message] [Debug log]
TestAccComputeInstanceTemplate_networkIPAddress[Error message] [Debug log]
TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log]
TestAccComputeInstanceTemplate_IP[Error message] [Debug log]
TestAccInstanceGroupManager_targetSizeZero[Error message] [Debug log]
TestAccInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeInstanceTemplate_regionDisks[Error message] [Debug log]
TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log]
TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log]
TestAccInstanceGroupManager_update[Error message] [Debug log]
TestAccInstanceGroupManager_basic[Error message] [Debug log]
TestAccInstanceGroupManager_versions[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_012_removableFields[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_overrideScratchDisk[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_overrideScheduling[Error message] [Debug log]
TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_overrideBootDisk[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout[Error message] [Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_overrideAttachedDisk[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_self_link_unique[Error message] [Debug log]
TestAccComputeInstanceFromTemplate_basic[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControlFixed[Error message] [Debug log]
TestAccComputeAutoscaler_scaleInControl[Error message] [Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance[Error message] [Debug log]
TestAccComputeAutoscaler_autoscalerBasicExample[Error message] [Debug log]
TestAccComputeBackendService_withMaxConnections[Error message] [Debug log]
TestAccComputeAutoscaler_update[Error message] [Debug log]
TestAccComputeAutoscaler_scalingSchedule[Error message] [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]
TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log]
TestAccComputeAutoscaler_multicondition[Error message] [Debug log]
TestAccInstanceTemplateDatasource_filter_mostRecent[Error message] [Debug log]
TestAccRegionInstanceTemplateDatasource_filter_mostRecent[Error message] [Debug log]
TestAccRegionInstanceTemplateDatasource_filter[Error message] [Debug log]
TestAccInstanceTemplateDatasource_self_link_unique[Error message] [Debug log]
TestAccRegionInstanceTemplateDatasource_name[Error message] [Debug log]
TestAccComputeBackendService_withBackend[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log]
TestAccInstanceTemplateDatasource_name[Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_fromIGM[Error message] [Debug log]
TestAccInstanceTemplateDatasource_filter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 force-pushed the labels-compute-instance-template branch 2 times, most recently from 6eee4fe to 38d8fe7 Compare September 22, 2023 23:26
@zli82016 zli82016 force-pushed the labels-compute-instance-template branch from 38d8fe7 to b967be6 Compare September 22, 2023 23:27
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 108 insertions(+), 30 deletions(-))
Terraform Beta: Diff ( 7 files changed, 113 insertions(+), 34 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 120 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 10 files changed, 125 insertions(+), 37 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3073
Passed tests 2766
Skipped tests: 306
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withSandboxConfig

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withSandboxConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 195 files changed, 1024 insertions(+), 304 deletions(-))
Terraform Beta: Diff ( 217 files changed, 1181 insertions(+), 391 deletions(-))

@zli82016 zli82016 force-pushed the labels-compute-instance-template branch 2 times, most recently from d575911 to 9cb76eb Compare September 25, 2023 05:04
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 198 files changed, 1036 insertions(+), 304 deletions(-))
Terraform Beta: Diff ( 221 files changed, 1195 insertions(+), 390 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2988
Passed tests 2678
Skipped tests: 306
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRegionInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_name|TestAccContainerNodePool_withSandboxConfig|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRegionInstanceTemplateDatasource_name[Debug log]
TestAccInstanceTemplateDatasource_name[Debug log]
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 force-pushed the labels-compute-instance-template branch from 9cb76eb to 7d1ee30 Compare September 25, 2023 16:25
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 198 files changed, 1036 insertions(+), 304 deletions(-))
Terraform Beta: Diff ( 221 files changed, 1195 insertions(+), 390 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3083
Passed tests 2766
Skipped tests: 315
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016 zli82016 merged commit e59be4f into FEATURE-BRANCH-major-release-5.0.0 Sep 25, 2023
@zli82016 zli82016 deleted the labels-compute-instance-template branch September 25, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants