improve autoscaling_policy support in google_compute_node_group

[NickElliot]

Fixes hashicorp/terraform-provider-google#13928

• node_group is now mutable
• Size is now an output only field
• inital_size or autoscaling_policy must be configured on resource creation

Release Note Template for Downstream PRs (will be copied)

compute: `size` in `google_compute_node_group` is now an output only field. 

compute: `google_compute_node_group` made mutable

compute: `google_compute_node_group` made to require one of `initial_size` or `autoscaling_policy` fields configured upon resource creation

[c2thorn]

There was an issue with contributor-membership-checker fixed yesterday, rebasing should fix @NickElliot

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 227 insertions(+), 63 deletions(-))
Terraform Beta: Diff ( 3 files changed, 227 insertions(+), 63 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2247
Passed tests 2000
Skipped tests: 243
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_withSoleTenantConfig|TestAccDataprocCluster_withNodeGroupAffinity|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 230 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 6 files changed, 230 insertions(+), 66 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 229 insertions(+), 66 deletions(-))
Terraform Beta: Diff ( 6 files changed, 229 insertions(+), 66 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3074
Passed tests 2759
Skipped tests: 306
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNodeGroup_fail|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_update|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNodeGroup_fail[Debug log]
TestAccComputeNodeGroup_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNodeGroup_nodeGroupBasicExample[Error message] [Debug log]
TestAccComputeNodeGroup_nodeGroupShareSettingsExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccContainerNodePool_withSandboxConfig[Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 9 files changed, 242 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[NickElliot]

Remaining tests referencing size over initial_size fixed, other test failures unrelated

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3074
Passed tests 2761
Skipped tests: 306
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNodeGroup_nodeGroupBasicExample[Error message] [Debug log]
TestAccComputeNodeGroup_nodeGroupShareSettingsExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Error message] [Debug log]
TestAccContainerNodePool_withSandboxConfig[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

Well, resource is working, theres just either a sweeper problem or quota problem, or too many tests are happening at once in the project 🙃

[c2thorn]

think CPU quota is no longer exceeded, going to rerun

[c2thorn]

/gcbrun

[c2thorn]

LGTM pending tests (hopefully we can get passing cassettes in)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3083
Passed tests 2762
Skipped tests: 314
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withSandboxConfig|TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNodeGroup_nodeGroupBasicExample[Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Debug log]
TestAccContainerCluster_withSoleTenantGroup[Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Debug log]
TestAccContainerNodePool_withSandboxConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNodeGroup_nodeGroupShareSettingsExample[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3083
Passed tests 2767
Skipped tests: 314
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNodeGroup_nodeGroupShareSettingsExample|TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNodeGroup_nodeGroupShareSettingsExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

One more try?

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3083
Passed tests 2769
Skipped tests: 313
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field size became Computed only on google_compute_node_group - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
Terraform Beta: Diff ( 8 files changed, 237 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3084
Passed tests 2769
Skipped tests: 314
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocCluster_withNodeGroupAffinity

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test