Breaking change: Stop deleting failed GKE clusters, taint instead#8978
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 11 insertions(+), 63 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_errorCleanDanglingCluster|TestAccDataSourceGoogleServiceAccountJwt |
|
Rerun these tests in REPLAYING mode to catch issues
|
| } | ||
| // The resource didn't actually create | ||
| // Don't clear cluster id, this will taint the resource | ||
| log.Printf("[WARN] GKE cluster %s was created in an error state, and has been marked as tainted", clusterName) |
There was a problem hiding this comment.
Checking: this works because just returning the error below automatically taints the resource.
There was a problem hiding this comment.
Returning an error without clearing the id, yep!
912551f
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Closes hashicorp/terraform-provider-google#4780
Release Note Template for Downstream PRs (will be copied)