Skip to content

Transitioned volumes.cloud_sql_instance.instances to SET from array#8929

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
ScottSuarez:v2cloudrunservice
Sep 12, 2023
Merged

Transitioned volumes.cloud_sql_instance.instances to SET from array#8929
ScottSuarez merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
ScottSuarez:v2cloudrunservice

Conversation

@ScottSuarez

@ScottSuarez ScottSuarez commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Fixes hashicorp/terraform-provider-google#13368

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: transitioned `volumes.cloud_sql_instance.instances` to SET from ARRAY for `google_cloud_run_v2_service`

@ScottSuarez ScottSuarez requested review from a team and roaks3 and removed request for a team September 12, 2023 20:02
@ScottSuarez ScottSuarez added the override-breaking-change Allows a potential breaking change to be merged label Sep 12, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field template.volumes.cloud_sql_instance.instances changed from TypeList to TypeSet on google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2703
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-breaking-change Allows a potential breaking change to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants