Update to wrap generated import format regex in ^ and $#8913
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 220 files changed, 680 insertions(+), 680 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeVpnTunnel_regionFromGateway|TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccBillingProjectInfo_update |
|
|
…ng supplied uris wth a trailing
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 225 files changed, 689 insertions(+), 690 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccBillingProjectInfo_update|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 227 files changed, 692 insertions(+), 695 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBillingProjectInfo_update|TestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 227 files changed, 692 insertions(+), 695 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountJwt |
|
Rerun these tests in REPLAYING mode to catch issues
|
rileykarson
left a comment
There was a problem hiding this comment.
LGTM- edited out "Fixes" In the parent since we'll need to add an upgrade guide as well, and proposed a changelog entry.
| ResourceName: "google_compute_vpn_tunnel.foobar", | ||
| ImportState: true, | ||
| ImportStateVerify: true, | ||
| ImportStateIdPrefix: fmt.Sprintf("%s/%s/", envvar.GetTestProjectFromEnv(), region), |
6cdbf4d
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Part of hashicorp/terraform-provider-google#14731
Currently generated import_format regex in TPG is not wrapped in start of line and end of line tokens, which allows for certain edge case false positives in non-standard import formats supplied via override.
Release Note Template for Downstream PRs (will be copied)