Change several fields in Access Context Manager from list to set#8788
Conversation
|
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 650 insertions(+), 534 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccProjectIamPolicy_invalidMembers |
|
Rerun these tests in REPLAYING mode to catch issues
|
shuyama1
left a comment
There was a problem hiding this comment.
As discussed offline with @Charlesleonius, they will add more test coverage and a upgrade entry in a separate PR to main branch. Thanks for working on this!
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 675 insertions(+), 534 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccFolderIamPolicy_basic |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 740 insertions(+), 537 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 801 insertions(+), 554 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 801 insertions(+), 554 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
shuyama1
left a comment
There was a problem hiding this comment.
Looks like some unit tests failed due to a recent CI change in our repo. Would you mind rebase your PR on top of 5.0.0 branch. It should resolve the issue. Thanks!
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeGroupIndexUpdate|TestAccDataprocJobIamPolicy|TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_described|TestAccLoggingProjectSink_basic|TestAccLoggingProjectSink_updateBigquerySink|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountJwt|TestAccSpannerDatabaseIamPolicy |
…om/GoogleCloudPlatform/magic-modules into FEATURE-BRANCH-major-release-5.0.0
…om/Charlesleonius/magic-modules into FEATURE-BRANCH-major-release-5.0.0
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 801 insertions(+), 554 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeGroupIndexUpdate|TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_described|TestAccLoggingProjectSink_basic|TestAccLoggingProjectSink_updateBigquerySink|TestAccSpannerInstanceIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 801 insertions(+), 554 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 955 insertions(+), 554 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
restricted_services = # value needed
vpc_accessible_services {
allowed_services = # value needed
}
}
status {
access_levels = # value needed
egress_policies {
egress_from {
identities = # value needed
}
egress_to {
external_resources = # value needed
resources = # value needed
}
}
ingress_policies {
ingress_from {
identities = # value needed
}
ingress_to {
resources = # value needed
}
}
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAccessContextManager|TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_described |
|
Rerun these tests in REPLAYING mode to catch issues
|
shuyama1
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding thorough tests!
665f32f
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Many of the fields for the Access Context Manager api are incorrectly defined as arrays. The fields are changed to sets to prevent duplicates and false positive diff reports when server side ordering changes.
fixes hashicorp/terraform-provider-google#13317
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)