Skip to content

Add google_bigquery_table to version 5 upgrade doc for #8460#8611

Merged
melinath merged 3 commits into
GoogleCloudPlatform:mainfrom
wj-chen:main
Aug 15, 2023
Merged

Add google_bigquery_table to version 5 upgrade doc for #8460#8611
melinath merged 3 commits into
GoogleCloudPlatform:mainfrom
wj-chen:main

Conversation

@wj-chen

@wj-chen wj-chen commented Aug 10, 2023

Copy link
Copy Markdown
Member

Add google_bigquery_table to version 5 upgrade doc for #8460.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@melinath

Copy link
Copy Markdown
Member

LGTM - merging without passing tests since this is a docs-only change.

@melinath melinath merged commit c4ff4eb into GoogleCloudPlatform:main Aug 15, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2951
Passed tests 2646
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample[Debug log]
TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
…tform#8460 (GoogleCloudPlatform#8611)

* add google_bigquery_table to version 5 upgrade doc for GoogleCloudPlatform#8460

* update wording

---------

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
…tform#8460 (GoogleCloudPlatform#8611)

* add google_bigquery_table to version 5 upgrade doc for GoogleCloudPlatform#8460

* update wording

---------

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…tform#8460 (GoogleCloudPlatform#8611)

* add google_bigquery_table to version 5 upgrade doc for GoogleCloudPlatform#8460

* update wording

---------

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants