Skip to content

Sync 5.0.0 with main part 1#8530

Merged
shuyama1 merged 9 commits into
FEATURE-BRANCH-major-release-5.0.0from
pre_tgc_beta_main
Aug 3, 2023
Merged

Sync 5.0.0 with main part 1#8530
shuyama1 merged 9 commits into
FEATURE-BRANCH-major-release-5.0.0from
pre_tgc_beta_main

Conversation

@shuyama1

@shuyama1 shuyama1 commented Aug 2, 2023

Copy link
Copy Markdown
Member

Split #8523, as the original PR keeps running into errors at tpc-base. In this way, it'd be easier to find what the root cause is

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


ibhaskar2 and others added 9 commits July 20, 2023 08:58
* Adding Support For resilience_mode field

* Adding new field RESILIENCE_MODE_UNSPECIFIED

* Added RESILIENCE_MODE_UNSPECIFIED in the docs

* Removing the resilience mode test as the API is not yet launched

* Adding test for high resilience and adding  mapping

* Fixing docs and flatten logic

* Fixing expand method

* Fixing flatten to accept empty Resilience_mode field

---------

Co-authored-by: Khaled Hassan <hkhaled@google.com>
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
* adding security_policy field in regionBackendService resource

* fixing code review to use http calls instead of lib in RegionBackendService

* removing ParseSecurityPolicyRegionalFieldValue method

* fixing lint issue
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 49 files changed, 435 insertions(+), 265 deletions(-))
Terraform Beta: Diff ( 53 files changed, 627 insertions(+), 301 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_backend_service (87 total tests)
Untested fields: security_policy

Please add acceptance tests which include these fields.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2876
Passed tests 2565
Skipped tests: 300
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccCloudIdsEndpoint_basic|TestAccComputeForwardingRule_ip|TestAccCloudTasksQueue_TimeUnitDiff|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccSecurityScannerScanConfig_scanConfigUpdate[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode[Debug log]
TestAccCloudIdsEndpoint_basic[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccCloudTasksQueue_TimeUnitDiff[Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

@shuyama1 shuyama1 requested a review from melinath August 3, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.