Sync 5.0.0 with main part 1#8530
Conversation
This reverts commit a3e513f.
Add `tpgresource.DurationDiffSuppress` to min / max backoff Fixes https://github.com/hashicorp/terraform-provider-google/issues/15166x
* Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>
* Fixed tf-test prefixes for compute addresses * Reverted unused example changes * Reverted unnecessary change
* adding security_policy field in regionBackendService resource * fixing code review to use http calls instead of lib in RegionBackendService * removing ParseSecurityPolicyRegionalFieldValue method * fixing lint issue
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 49 files changed, 435 insertions(+), 265 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: Please add acceptance tests which include these fields. |
Tests analyticsTotal tests: Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComposerEnvironment_UpdateComposerV2ResilienceMode|TestAccCloudIdsEndpoint_basic|TestAccComputeForwardingRule_ip|TestAccCloudTasksQueue_TimeUnitDiff|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues$\textcolor{green}{\textsf{All tests passed!}} |
Split #8523, as the original PR keeps running into errors at tpc-base. In this way, it'd be easier to find what the root cause is
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)