Skip to content

Enforce mutual exclusivity among view, materialized view, and schema in BigQuery table config#8494

Closed
wj-chen wants to merge 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
wj-chen:FEATURE-BRANCH-major-release-5.0.0
Closed

Enforce mutual exclusivity among view, materialized view, and schema in BigQuery table config#8494
wj-chen wants to merge 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
wj-chen:FEATURE-BRANCH-major-release-5.0.0

Conversation

@wj-chen

@wj-chen wj-chen commented Jul 31, 2023

Copy link
Copy Markdown
Member

Fixes hashicorp/terraform-provider-google#14220.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed view and materialized view creation when schema is specified

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 155 insertions(+), 49 deletions(-))
Terraform Beta: Diff ( 2 files changed, 155 insertions(+), 49 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2875
Passed tests 2572
Skipped tests: 300
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccBigQueryTable_MaterializedView_WithView|TestAccBigQueryTable_MaterializedView_WithSchema

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_MaterializedView_WithView[Debug log]
TestAccBigQueryTable_MaterializedView_WithSchema[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccBigQueryTable_MaterializedView_WithSchema[Error message] [Debug log]
TestAccBigQueryTable_MaterializedView_WithView[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@wj-chen

wj-chen commented Jul 31, 2023

Copy link
Copy Markdown
Member Author

This commit was cherry-picked from #7973. The affected tests pass locally:

--- PASS: TestAccBigQueryTable_MaterializedView_WithView (0.57s)
--- PASS: TestAccBigQueryTable_MaterializedView_WithSchema (0.56s)

@rileykarson

Copy link
Copy Markdown
Member

@melinath assigning as you're the reviewer of the last PR. We could retarget the original as well, which may be preferred, since most of the review happened inline there.

@melinath

melinath commented Aug 1, 2023

Copy link
Copy Markdown
Member

+1 re: retargeting the first PR (#7973) to not lose context. Closing this PR for now.

@melinath melinath closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants