-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature/support Add support for L4 Internal Loadbalancer with IPv6 #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rileykarson
merged 6 commits into
GoogleCloudPlatform:main
from
ericayyliu:feature/support-ipv6-forwarding-rule
Aug 2, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a01c03b
Add support for L4 Internal Loadbalancer with IPv6
ericayyliu 6fc0022
Add support for L4 Internal Loadbalancer with IPv6
ericayyliu c83d360
Merge branch 'GoogleCloudPlatform:main' into feature/support-ipv6-for…
ericayyliu 8e3b12a
Add support for L4 Internal Loadbalancer with IPv6
ericayyliu e123843
Merge branch 'GoogleCloudPlatform:main' into feature/support-ipv6-for…
ericayyliu b953ae9
Add support for L4 Internal Loadbalancer with IPv6
ericayyliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
mmv1/templates/terraform/examples/forwarding_rule_internallb_ipv6.tf.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Forwarding rule for Internal Load Balancing | ||
| resource "google_compute_forwarding_rule" "<%= ctx[:primary_resource_id] %>" { | ||
| name = "<%= ctx[:vars]['forwarding_rule_name'] %>" | ||
| region = "us-central1" | ||
|
|
||
| load_balancing_scheme = "INTERNAL" | ||
| backend_service = google_compute_region_backend_service.backend.id | ||
| all_ports = true | ||
| network = google_compute_network.default.name | ||
| subnetwork = google_compute_subnetwork.default.name | ||
| ip_version = "IPV6" | ||
| } | ||
|
|
||
| resource "google_compute_region_backend_service" "backend" { | ||
| name = "<%= ctx[:vars]['backend_name'] %>" | ||
| region = "us-central1" | ||
| health_checks = [google_compute_health_check.hc.id] | ||
| } | ||
|
|
||
| resource "google_compute_health_check" "hc" { | ||
| name = "check-<%= ctx[:vars]['backend_name'] %>" | ||
| check_interval_sec = 1 | ||
| timeout_sec = 1 | ||
|
|
||
| tcp_health_check { | ||
| port = "80" | ||
| } | ||
| } | ||
|
|
||
| resource "google_compute_network" "default" { | ||
| name = "<%= ctx[:vars]['network_name'] %>" | ||
| auto_create_subnetworks = false | ||
| enable_ula_internal_ipv6 = true | ||
| } | ||
|
|
||
| resource "google_compute_subnetwork" "default" { | ||
| name = "<%= ctx[:vars]['subnet_name'] %>" | ||
| ip_cidr_range = "10.0.0.0/16" | ||
| region = "us-central1" | ||
| stack_type = "IPV4_IPV6" | ||
| ipv6_access_type = "INTERNAL" | ||
| network = google_compute_network.default.id | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, I just thought of a possible failure case. Some APIs, GCE in particular, will sometimes return a null when the default value is returned from the API. Could you amend an existing test to explicitly send
IPV4? That'll confirm whether we need to mitigate that behaviour here or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I'll try modify one basic test case. Bth, should we do
default_value = IPV4, instead ofdefault_from_api=true?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is fine. Since the field is immutable,
default_from_apiis a little safer. Explicit default values create a slightly cleaner plan, though, since the default value is known when planning.