Allow dns_authorization to be imported#7455
Closed
ScottSuarez wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
duplicate of #7445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#13487
dns_authorizationwas ignore read in the original implementation of this resource. Reason being that the entries in thedns_authorizationarray will have theirproject_idreplaced with aproject_number. Using aDiffSuppressFunc: projectNumberDiffSuppressis sufficient here. Upon testing they are not sorting the array they return but simply replacing the values therein. Thus using this diffsupress func should be sufficient as opposed to a customizeDiff function which would be needed if the array values were sorted.Release Note Template for Downstream PRs (will be copied)