[Terraform]: Add support for Google Cloud Bigtable replication#588
Closed
rileykarson wants to merge 3 commits into
Closed
[Terraform]: Add support for Google Cloud Bigtable replication#588rileykarson wants to merge 3 commits into
rileykarson wants to merge 3 commits into
Conversation
Collaborator
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
chrisst
approved these changes
Oct 19, 2018
Collaborator
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit bf5a8f5) have been included in your existing downstream PRs. |
8d7d1f3 to
9465b8f
Compare
Collaborator
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit f174720) have been included in your existing downstream PRs. |
9465b8f to
aec3680
Compare
aec3680 to
f4afb91
Compare
Collaborator
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit c9254c2) have been included in your existing downstream PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed midway through that we hadn't added the tests yet. Oops! You can break down by commit to see the test changes separately.
Fixes hashicorp/terraform-provider-google#1672
[all]
[terraform]
Add support for Google Cloud Bigtable replication
[terraform-beta]
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]
[inspec]