Skip to content

Add OiCS link generation to the Terraform docs.#572

Merged
modular-magician merged 12 commits into
GoogleCloudPlatform:masterfrom
rileykarson:oics-links
Oct 19, 2018
Merged

Add OiCS link generation to the Terraform docs.#572
modular-magician merged 12 commits into
GoogleCloudPlatform:masterfrom
rileykarson:oics-links

Conversation

@rileykarson

Copy link
Copy Markdown
Member

@paddycarver

I threw up some content so that these links work while using make website - they should all be fully functional.

I ended up needing to use HTML instead of just markdown to add the buttons, which wasn't entirely unexpected but kind of unfortunate. Let me know if you have issues with how it behaves when you resize a window.

This will update the docs in the 2.0.0 branch - once this is merged, I'm going to cherry pick the commit against an older MM commit and manually PR into tpg master, adding you for review. We'll merge Monday and website release then, or very early Tuesday.

These git shenanigans will probably end up causing a merge conflict while merging 2.0.0 -> master, but the MM HEAD will be the source of truth - we can just clobber the changes. From 2.0.0 on, we won't need to do any fooling around with git and the docs will be updated normally alongside website releases.

Docs look like:

image


[all]

[terraform]

Add Open in Cloud Shell links to docs

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

@modular-magician

Copy link
Copy Markdown
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#2269

@modular-magician

Copy link
Copy Markdown
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit e9f919b) have been included in your existing downstream PRs.

@paddycarver

Copy link
Copy Markdown
Contributor

I ended up needing to use HTML instead of just markdown to add the buttons, which wasn't entirely unexpected but kind of unfortunate. Let me know if you have issues with how it behaves when you resize a window.

I don't mind the HTML. When viewing on a tiny screen (think phone), though, I think it'd be better if the button dropped to below the headline.

I think I followed the git shenanigans plan, and trust you on it :)

I ran this locally on a couple of things, and I don't have it in me to try all the examples, but everything I saw looked good.

I think if we can get the button on phones issue resolved, I'm 👍 on this.

Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit b6e66c2 into GoogleCloudPlatform:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants