Skip to content

move private connectivity tests to us-west1#17614

Merged
NickElliot merged 4 commits into
GoogleCloudPlatform:mainfrom
NickElliot:dbmspctestissue
May 21, 2026
Merged

move private connectivity tests to us-west1#17614
NickElliot merged 4 commits into
GoogleCloudPlatform:mainfrom
NickElliot:dbmspctestissue

Conversation

@NickElliot
Copy link
Copy Markdown
Contributor

@NickElliot NickElliot commented May 18, 2026

max upper quota for "PrivateConnectionsPerProjectAndRegion" is 5, we were at 6 tests using us-central 1

moved both dbms resources using a private connectivity resource to us-west1, and one datastream to it to create a small buffer

fixes hashicorp/terraform-provider-google#27340

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3764843:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 8 insertions(+), 8 deletions(-)
google-beta provider View Diff 4 files changed, 8 insertions(+), 8 deletions(-)
Open in Cloud Shell View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 24 10 3
Affected Service Packages
  • databasemigrationservice
  • datastream

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
  • TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
❌ Error · Log - TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
❌ Error · Log - TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 3764843!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 19, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e6b50e4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 10 insertions(+), 10 deletions(-)
google-beta provider View Diff 4 files changed, 10 insertions(+), 10 deletions(-)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Cloud Shell View Diff 2 files changed, 3 insertions(+), 3 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 24 10 3
Affected Service Packages
  • databasemigrationservice
  • datastream

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
  • TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
❌ Error · Log - TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
❌ Error · Log - TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for e6b50e4!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 19, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4ad3120:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 14 insertions(+), 14 deletions(-)
google-beta provider View Diff 4 files changed, 14 insertions(+), 14 deletions(-)
Open in Cloud Shell View Diff 2 files changed, 4 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 24 10 3
Affected Service Packages
  • databasemigrationservice
  • datastream

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
  • TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
  • TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
✅ Log TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
❌ Error · Log - TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for 4ad3120!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 19, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d20b184:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 14 insertions(+), 14 deletions(-)
google-beta provider View Diff 4 files changed, 14 insertions(+), 14 deletions(-)
Open in Cloud Shell View Diff 2 files changed, 4 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 26 10 1
Affected Service Packages
  • datastream
  • databasemigrationservice

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDatastreamPrivateConnection_datastreamPrivateConnectionPscInterfaceExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@NickElliot VCR tests complete for d20b184!

@NickElliot NickElliot changed the title move private connectivity tests to us-central2 move private connectivity tests to us-west1 May 19, 2026
@NickElliot NickElliot marked this pull request as ready for review May 19, 2026 17:44
@NickElliot
Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot May 19, 2026 17:44
@NickElliot NickElliot added this pull request to the merge queue May 21, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 29e0bdc May 21, 2026
27 checks passed
@NickElliot NickElliot deleted the dbmspctestissue branch May 21, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample

3 participants