Skip to content

feat: add goldengate deployment resource and tests#17604

Open
swethamagesh14 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
swethamagesh14:gg-deployment-final
Open

feat: add goldengate deployment resource and tests#17604
swethamagesh14 wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
swethamagesh14:gg-deployment-final

Conversation

@swethamagesh14
Copy link
Copy Markdown

@swethamagesh14 swethamagesh14 commented May 18, 2026

Part of hashicorp/terraform-provider-google#27426

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_oracle_database_goldengate_deployment`

@github-actions github-actions Bot requested a review from slevenick May 18, 2026 08:07
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ae71251:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 3967 insertions(+)
google-beta provider View Diff 4 files changed, 3967 insertions(+)
terraform-google-conversion View Diff 1 file changed, 1214 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 260 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_goldengate_deployment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_goldengate_deployment" "primary" {
  properties {
    description = # value needed
    ogg_data {
      admin_password_secret_version = # value needed
      ogg_version                   = # value needed
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
31 27 2 2
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentBasicExample
  • TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentBasicExample
✅ Log TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@swethamagesh14, @slevenick VCR tests complete for ae71251!

custom_code:
pre_delete: "templates/terraform/pre_delete/oracledatabase_goldengate_deployment.go.tmpl"
virtual_fields:
- name: "deletion_protection"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using deletion_policy here as documented in this PR: #17445

We're standardizing on deletion policy as a first-class setting

@github-actions github-actions Bot requested a review from slevenick May 21, 2026 06:43
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 05d1833:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 3972 insertions(+)
google-beta provider View Diff 4 files changed, 3972 insertions(+)
terraform-google-conversion View Diff 1 file changed, 1214 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 262 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
31 28 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccOracleDatabaseGoldengateDeployment_oracledatabaseGoldengateDeploymentFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@swethamagesh14, @slevenick VCR tests complete for 05d1833!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants