feat: add goldengate deployment resource and tests#17604
feat: add goldengate deployment resource and tests#17604swethamagesh14 wants to merge 4 commits into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ae71251: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_goldengate_deployment" "primary" {
properties {
description = # value needed
ogg_data {
admin_password_secret_version = # value needed
ogg_version = # value needed
}
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @swethamagesh14, @slevenick VCR tests complete for ae71251! |
| custom_code: | ||
| pre_delete: "templates/terraform/pre_delete/oracledatabase_goldengate_deployment.go.tmpl" | ||
| virtual_fields: | ||
| - name: "deletion_protection" |
There was a problem hiding this comment.
Prefer using deletion_policy here as documented in this PR: #17445
We're standardizing on deletion policy as a first-class setting
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 05d1833: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @swethamagesh14, @slevenick VCR tests complete for 05d1833! |
Part of hashicorp/terraform-provider-google#27426
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.